This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
feat(css): allow the css prop to accept fns and strings
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
requested review from
vesparny,
atticoos,
paulmolluzzo,
luke-john and
kkemple
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 139 142 +3
Branches 35 35
=====================================
+ Hits 139 142 +3
Continue to review full report at Codecov.
|
kentcdodds
force-pushed
the
pr/css-as-function
branch
from
acfe0c2 to
6bbb9c3
Compare
**What**: Closes #170 **Why**: enables code reuse and potentially "Ahead of Time compilation" **How**: - Reusing the same logic for `cssOverrides` as we use for `styles` in `get-glamor-classname.js`. Tiny refactor there. - Adding tests to cover all the cases for the API.
kentcdodds
force-pushed
the
pr/css-as-function
branch
from
6bbb9c3 to
d91e9a4
Compare
kentcdodds
commented
Jun 9, 2017
| @@ -4,16 +4,13 @@ const glamorous = glamorousStar.default | |||
|
|
|||
| Object.assign( | |||
| glamorous, | |||
| Object.keys(glamorousStar).reduce( | |||
There was a problem hiding this comment.
prettier update. I didn't change anything here
kkemple
approved these changes
Jun 10, 2017
luke-john
approved these changes
Jun 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #170
Why: enables code reuse and potentially "Ahead of Time compilation"
How:
cssOverridesas we use forstylesinget-glamor-classname.js. Tiny refactor there.Checklist:
I also updated deps because I think prettier was messed up.